P2897 (aligned_accessor): Update to R2 #461
Closed
+1,597
−720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update based on further discussion with David Sankel.
* Rename `is_checkably_valid` to `detectably_invalid`
(with inverted return value)
* Ask LEWG to consider the alternative design that makes
`is_sufficiently_aligned` a nonmember function in `<bit>`
instead of a member function of `aligned_accessor`,
while LWG review of R2 proceeds concurrently
* P2389R2 was voted into the Working Draft at St. Louis,
so replace use of `dextents` in examples with `dims`.
* Minor formatting and non-wording fixes
Add non-wording section explaining why `aligned_accessor` has no `explicit` constructor from less to more alignment.
This was referenced Jul 12, 2024
|
Superseded by PR #466 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crtrott @dalg24 Update based on discussion with David Sankel. I submitted this as P2897R2 on 2024/07/12.
Update: Please merge this before the R3 PR #463 ; thanks!