Skip to content

Commit

Permalink
replace fixnum w/ integer
Browse files Browse the repository at this point in the history
Fixes #67
  • Loading branch information
Jeremy Nicklas committed Apr 2, 2018
1 parent 3acf156 commit 7955e7c
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 12 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Basic multi-cluster support for LSF by specifying name of cluster for -m
argument. [#24](https://github.com/OSC/ood_core/issues/24)

### Fixed
- Replaced `Fixnum` code comments with `Integer`.
[#67](https://github.com/OSC/ood_core/issues/67)

## [0.2.1] - 2018-01-26
### Changed
- Updated the date in the `LICENSE.txt` file.
Expand Down
2 changes: 1 addition & 1 deletion lib/ood_core/job/adapters/lsf/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def estimate_runtime(current_time:, start_time:, finish_time:)
#
# my guess is: hours:minutes:seconds.????
#
# @return [Fixnum, nil] cpu used as seconds
# @return [Integer, nil] cpu used as seconds
def parse_cpu_used(cpu_used)
if cpu_used =~ /^(\d+):(\d+):(\d+)\..*$/
$1.to_i*3600 + $2.to_i*60 + $3.to_i
Expand Down
10 changes: 5 additions & 5 deletions lib/ood_core/job/info.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,23 @@ class Info
attr_reader :accounting_id

# Number of procs allocated for job
# @return [Fixnum, nil] allocated total number of procs
# @return [Integer, nil] allocated total number of procs
attr_reader :procs

# Name of the queue in which the job was queued or started
# @return [String, nil] queue name
attr_reader :queue_name

# The accumulated wall clock time in seconds
# @return [Fixnum, nil] wallclock time
# @return [Integer, nil] wallclock time
attr_reader :wallclock_time

# The total wall clock time limit in seconds
# @return [Fixnum, nil] wallclock time limit
# @return [Integer, nil] wallclock time limit
attr_reader :wallclock_limit

# The accumulated CPU time in seconds
# @return [Fixnum, nil] cpu time
# @return [Integer, nil] cpu time
attr_reader :cpu_time

# The time at which the job was submitted
Expand Down Expand Up @@ -139,7 +139,7 @@ def eql?(other)
end

# Generate a hash value for this object
# @return [Fixnum] hash value of object
# @return [Integer] hash value of object
def hash
[self.class, to_h].hash
end
Expand Down
4 changes: 2 additions & 2 deletions lib/ood_core/job/node_info.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class NodeInfo
attr_reader :name

# The number of procs reserved on the given machine
# @return [Fixnum, nil] number of procs
# @return [Integer, nil] number of procs
attr_reader :procs

# @param name [#to_s] node name
Expand Down Expand Up @@ -38,7 +38,7 @@ def eql?(other)
end

# Generate a hash value for this object
# @return [Fixnum] hash value of object
# @return [Integer] hash value of object
def hash
[self.class, to_h].hash
end
Expand Down
6 changes: 3 additions & 3 deletions lib/ood_core/job/script.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Script
attr_reader :queue_name

# The scheduling priority for the job
# @return [Fixnum, nil] scheduling priority
# @return [Integer, nil] scheduling priority
attr_reader :priority

# The earliest time when the job may be eligible to run
Expand All @@ -84,7 +84,7 @@ class Script

# The maximum amount of real time during which the job can be running in
# seconds
# @return [Fixnum, nil] max real time
# @return [Integer, nil] max real time
attr_reader :wall_time

# The attribute used for job accounting purposes
Expand Down Expand Up @@ -189,7 +189,7 @@ def eql?(other)
end

# Generate a hash value for this object
# @return [Fixnum] hash value of object
# @return [Integer] hash value of object
def hash
[self.class, to_h].hash
end
Expand Down
2 changes: 1 addition & 1 deletion lib/ood_core/job/status.rb
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def eql?(other)
end

# Generate a hash value for this object
# @return [Fixnum] hash value of object
# @return [Integer] hash value of object
def hash
[self.class, to_sym].hash
end
Expand Down

0 comments on commit 7955e7c

Please sign in to comment.