Fix Broken Links #871
Fix Broken Links #871
Conversation
geographika
force-pushed
the
link-fixes
branch
5 times, most recently
from
9c9f9ee
to
9e95795
Compare
|
The linkchecking is quite flaky. I think all URLs across all languages are checked on every pull request by https://github.com/OSGeo/OSGeoLive-doc/blob/master/.github/workflows/linkcheck.yml as the https://github.com/OSGeo/OSGeoLive-doc/blob/master/.github/workflows/locale-update.yml action updates the language files automatically. Maybe the linkcheck action should only be triggered by specific tags in a commit? Otherwise most doc pull requests will fail for unrelated reasons. https://demo.pycsw.org/ is now failing having passed the tests all morning, and seems fine in a browser. |
geographika
force-pushed
the
link-fixes
branch
4 times, most recently
from
26b004d
to
5f93613
Compare
Ignore https://demo.pycsw.org Increase the number of retries URL fixes in language translations Ignore freenode checks and update GDAL tutorial links Ignore StackOverflow link checks as they are rate limited Update permanent redirects
geographika
force-pushed
the
link-fixes
branch
from
d6359bd
to
86d3417
Compare
|
With the various fixes and increased retries, the checks currently seem stable (green ticks across all CI checks for 3 pushes in a row). Ready to merge from my side. |
| @@ -29,11 +29,11 @@ Software | |||
| ---------------- | |||
| Download the VM version of OSGeoLive. You will need the 7-zip compression program to unzip this file. And of course the VMWare Player software for running the virtual machine. Note that VMWare Player, while offered as a cost-free download, is not open source. You must register on the VMWare website, and agree to their licence in order to use the software.: | |||
|
|
|||
| `The OSGeo virtual machine <http://download.osgeo.org/livedvd/release/5.5/osgeolive-vm-5.5.7z>`_ | |||
| `The OSGeo virtual machine <https://download.osgeo.org/livedvd/releases/5.5/>`_ | |||
There was a problem hiding this comment.
V5.5 is very old, perhaps point to the parent directory (and update the file header above?).
Or, make it clear (also below) that "5.5" is just an example?
There was a problem hiding this comment.
@neteler vmware_quickstart.rst isn't linked to from anywhere and isn't available at https://live.osgeo.org/en/quickstart/vmware_quickstart.html so I'm thinking this whole file is outdated and could be removed?
Co-authored-by: Markus Neteler <markus@neteler.org>
Co-authored-by: Markus Neteler <markus@neteler.org>
Co-authored-by: Markus Neteler <markus@neteler.org>
Co-authored-by: Markus Neteler <markus@neteler.org>
Co-authored-by: Markus Neteler <markus@neteler.org>
Co-authored-by: Markus Neteler <markus@neteler.org>
…ver Error' in CI
|
(I have fixed the ZOO URLs in 0364236, now the CI passes.) |
|
Thanks for the review @neteler. I've addressed all the comments, apart from the VMWare link. The VMWare page is very outdated (referring to OSGeoLive 5.5), so should either be removed or updated and tested in a separate pull request. |
CI builds are currently failing due to broken links in the docs.
This pull request:
Questions:
doc/quickstart/vmware_quickstart.rstbe removed? It is not in the HTML output and is written for OSGeoLive 5.5.