Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.stac: Updated dependency versions, adding lazy loading #1189

Merged
merged 12 commits into from
Sep 23, 2024

Conversation

@cwhite911 cwhite911 marked this pull request as ready for review August 29, 2024 19:43
@petrasovaa
Copy link
Contributor

@cwhite911 I can't review this very much, but I think we can merge this, no?

@cwhite911
Copy link
Contributor Author

cwhite911 commented Sep 5, 2024

Yes, we can merge it. Maybe just check that the lazy imports work as expected on your end.

@neteler
Copy link
Member

neteler commented Sep 21, 2024

The CI shows an error (found via #1119):

https://github.com/OSGeo/grass-addons/actions/runs/10971942436/job/30467639801?pr=1119

Run flake8 --count --statistics --show-source --jobs="$(nproc)" .
./src/temporal/t.stac/t.stac.item/t.stac.item.py:393:39: E201 whitespace after '{'
    gs.message(_(f"Asset Media Type: { MediaType(asset.get('type')).name}"))
                                      ^
1     E201 whitespace after '{'
1
Error: Process completed with exit code 1.

and another error here (found via #1174):

https://github.com/OSGeo/grass-addons/actions/runs/10971938932/job/30467631313?pr=1174

MARKDOWN_PRETTIER
  2024-09-21 10:46:06 [INFO]   Linting MARKDOWN_PRETTIER items...
  Error: -21 10:46:09 [ERROR]   Found errors when linting MARKDOWN_PRETTIER. Exit code: 1.
  2024-09-21 10:46:09 [INFO]   Command output for MARKDOWN_PRETTIER:
  ------
  Checking formatting...
  ------
  2024-09-21 10:46:09 [INFO]   Stderr contents for MARKDOWN_PRETTIER:
  ------
  [warn] .github/ISSUE_TEMPLATE/bug_report.md
  [warn] src/temporal/t.stac/README.md
  [warn] Code style issues found in 2 files. Run Prettier with --write to fix.

@cwhite911
Copy link
Contributor Author

The code was from previous commit.

Run flake8 --count --statistics --show-source --jobs="$(nproc)" .
./src/temporal/t.stac/t.stac.item/t.stac.item.py:393:39: E201 whitespace after '{'
    gs.message(_(f"Asset Media Type: { MediaType(asset.get('type')).name}"))
                                      ^
1     E201 whitespace after '{'
1
Error: Process completed with exit code 1.

@echoix echoix merged commit 96a6bd1 into OSGeo:grass8 Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants