cronjobs: new filename scheme and G84 added #896

neteler · 2023-05-18T18:04:46Z

Following the creation of the new GRASS GIS 8.3 release branch an overhaul of the cronjob scripts is needed.

label	meaning
legacy	legacy stable version, no longer recommended for use
old current	current stable version, widely used
new current	upcoming stable version, for early adopters
preview	development version, for developers and new feature enthusiasts

The labels follow the download sections on https://grass.osgeo.org/download/ (see operating system subpages).

Following this filename scheme, the cronjob files have been renamed and new files been added:

renamed: cron_grass7_relbranch_build_binaries.sh -> cron_grass_legacy_build_binaries.sh
renamed: cron_grass7_relbranch_src_snapshot.sh -> cron_grass_legacy_src_snapshot.sh
renamed: cron_grass8_main_build_binaries.sh -> cron_grass_new_current_build_binaries.sh
renamed: cron_grass8_main_src_snapshot.sh -> cron_grass_new_current_src_snapshot.sh
renamed: cron_grass8_relbranch_build_binaries.sh -> cron_grass_old_current_build_binaries.sh
renamed: cron_grass8_relbranch_src_snapshot.sh -> cron_grass_old_current_src_snapshot.sh
new file: cron_grass_preview_build_binaries.sh
new file: cron_grass_preview_src_snapshot.sh

Importantly, no version numbers are part of the file names to gain long term stability.

In case of version increments, "just" the versions coded in the file(s) need to be updated and (in some cases) new directories been created on grass.osgeo.org - see respective comments in the cron_grass*.sh files.

Note: the redundancy in the files may be addressed by refactoring in a separate PR.

Following the creation of the new GRASS GIS 8.3 release branch an overhaul of the cronjob scripts is needed. | **label** | **version number** | | ----------- | ------------------ | | legacy | 7.8 | | old current | 8.2 | | new current | 8.3 | | preview | 8.4 | Following this file name scheme, the cronjob files have been renamed and new files been added: * renamed: cron_grass7_relbranch_build_binaries.sh -> cron_grass7_legacy_build_binaries.sh * renamed: cron_grass7_relbranch_src_snapshot.sh -> cron_grass7_legacy_src_snapshot.sh * renamed: cron_grass8_main_build_binaries.sh -> cron_grass8_new_current_build_binaries.sh * renamed: cron_grass8_main_src_snapshot.sh -> cron_grass8_new_current_src_snapshot.sh * renamed: cron_grass8_relbranch_build_binaries.sh -> cron_grass8_old_current_build_binaries.sh * renamed: cron_grass8_relbranch_src_snapshot.sh -> cron_grass8_old_current_src_snapshot.sh * new file: cron_grass8_preview_build_binaries.sh * new file: cron_grass8_preview_src_snapshot.sh Importantly, no version numbers are part of the file names to gain long term stability. In case of version increments, "just" the versions coded in the file(s) need to be updated and (in some cases) new directories been created on grass.osgeo.org (see respective comments in the `cron_grass*.sh` files).

wenzeslaus

The new names still contain version although "no version numbers are part of the file names" is stated as one of the goals.
Same issue, different take on it: The names grass7 and grass8 go against the Usage section of Version Numbering RFC: "Version should be considered a separate item from the name." Or in other words, 7 and 8 are not part the name, but really version numbers.

ninsbl · 2023-05-18T18:55:33Z

See also #814 for a more comprehensive change with regards to removing version numbers. May be you can take over / finish of that PR?

wenzeslaus · 2023-05-18T18:56:36Z

utils/cronjobs_osgeo_lxd/README.md

+ * grass8-old-current (current stable): `cron_grass8_old_current_src_snapshot.sh`
+ * grass8-new-current (new stable): `cron_grass8_new_current_src_snapshot.sh`


If you want to explain somewhere what the strange "old current" means, use the overview table for that instead of trying to fix a cryptic name for each entry in this list.

Polished in 15f4a5d: See updated README.md

All the pieces except the file name are not necessary, but we can address that later in something like #814.

What I mean is that it is basically just repeating the file name (the thing with dashes) and then the table (the thing in parentheses), so it brings more characters, not more information.

wenzeslaus · 2023-05-18T18:56:39Z

utils/cronjobs_osgeo_lxd/README.md

+ * grass7-stable (legacy): `cron_grass7_legacy_src_snapshot.sh`
+ * grass8-old-current (current stable): `cron_grass8_old_current_src_snapshot.sh`
+ * grass8-new-current (new stable): `cron_grass8_new_current_src_snapshot.sh`
+ * grass8-preview (development): `cron_grass8_preview_src_snapshot.sh`


I have no idea where these labels such as grass8-new-current appear.

Polished in 15f4a5d

Where does the thing with dashes appear except for this list?

It doesn't. It is an "summary" item explanation to not just list the name of the file there.

Better suggestions (please edit directly) are welcome.

If I would edit that I would just delete the whole part because the clarity needs to be in the file names not in a possibly outdated list plus-I-don't-get-the-dashes-there, so I pass.

Ok, removed in 1a3d988

utils/cronjobs_osgeo_lxd/cron_grass8_old_current_src_snapshot.sh

utils/cronjobs_osgeo_lxd/cron_grass8_new_current_src_snapshot.sh

utils/cronjobs_osgeo_lxd/README.md

neteler · 2023-05-18T19:47:35Z

See also #814 for a more comprehensive change with regards to removing version numbers. May be you can take over / finish of that PR?

Oh, I wasn't any more aware of that. Not sure if I find the time in the next days to redo everything.

neteler · 2023-05-18T19:48:06Z

So I kick this PR.

wenzeslaus · 2023-05-19T01:37:56Z

This one is actually closer to what we need to release 8.3.0-RC1, but it depends when we want to release it.

neteler · 2023-05-20T06:39:41Z

This PR might be the interim one.

…ADME.md

neteler · 2023-05-23T16:28:34Z

The new names still contain version although "no version numbers are part of the file names" is stated as one of the goals.

Fixed.

2. Same issue, different take on it: The names _grass7_ and _grass8_ go against the _Usage_ section of [Version Numbering RFC](https://github.com/OSGeo/grass/blob/main/doc/development/rfc/version_numbering.md): "Version should be considered a separate item from the name." Or in other words, 7 and 8 are not part the name, but really version numbers.

Yes, changed.

wenzeslaus · 2023-05-23T17:56:02Z

It's not clear to me if the line GPATCH=1 # required by grass-addons-index.sh needs an update or not.

wenzeslaus · 2023-05-23T17:58:29Z

It's not clear to me if the line GPATCH=1 # required by grass-addons-index.sh needs an update or not.

Oh, it's clear to me now. It's for 8.2.1. The others have 0dev as micro as they should.

neteler · 2023-05-25T22:21:29Z

@wenzeslaus Anything serious yet missing? I'd like to move on with this topic (and the PR is blocked).

Relevant issues have been addressed

@ninsbl

After merging of OSGeo#896 and cronjob deployment on grass.osgeo.org various issues came up which are addressed in this PR. Important: - fix incorrect branch in `cron_grass_new_current_build_binaries.sh` - generate programmer's manual only in `cron_grass_new_current_build_binaries.sh` Improvements: - fail early rather than useless continuation (`set -e`) - compile with 2 cores (`make -j2`) - fix copying of `INSTALL` and `REQUIREMENTS.html` to server download directory as being renamed to `INSTALL.md` and `REQUIREMENTS.md` - also copy `CITATION.cff` to server download directory Misc: - no longer generate gettext `.pot` file for transifex since we migrated to https://weblate.osgeo.org/projects/grass-gis/ This PR potentially also addresses OSGeo#814 (can @ninsbl please verify what's yet missing)?

After merging of #896 and cronjob deployment on grass.osgeo.org various issues came up which are addressed in this PR. Important: - fix incorrect branch in `cron_grass_new_current_build_binaries.sh` - generate programmer's manual only in `cron_grass_new_current_build_binaries.sh` Improvements: - fail early rather than useless continuation (`set -e`) - compile with 2 cores (`make -j2`) - fix copying of `INSTALL` and `REQUIREMENTS.html` to server download directory as being renamed to `INSTALL.md` and `REQUIREMENTS.md` - also copy `CITATION.cff` to server download directory Misc: - no longer generate gettext `.pot` file for transifex since we migrated to https://weblate.osgeo.org/projects/grass-gis/ (this PR potentially also addresses #814)

Following the creation of the new GRASS GIS 8.3 release branch an overhaul of the cronjob scripts is needed. | **label** | **meaning** | | ----------- | --------------------------------------------------------------- | | legacy | legacy stable version, no longer recommended for use | | old current | current stable version, widely used | | new current | upcoming stable version, for early adopters | | preview | development version, for developers and new feature enthusiasts | The labels follow the download sections on https://grass.osgeo.org/download/ (see operating system subpages). Following this filename scheme, the cronjob files have been renamed and new files been added: * renamed: `cron_grass7_relbranch_build_binaries.sh -> cron_grass_legacy_build_binaries.sh` * renamed: `cron_grass7_relbranch_src_snapshot.sh -> cron_grass_legacy_src_snapshot.sh` * renamed: `cron_grass8_main_build_binaries.sh -> cron_grass_new_current_build_binaries.sh` * renamed: `cron_grass8_main_src_snapshot.sh -> cron_grass_new_current_src_snapshot.sh` * renamed: `cron_grass8_relbranch_build_binaries.sh -> cron_grass_old_current_build_binaries.sh` * renamed: `cron_grass8_relbranch_src_snapshot.sh -> cron_grass_old_current_src_snapshot.sh` * new file: `cron_grass_preview_build_binaries.sh` * new file: `cron_grass_preview_src_snapshot.sh` Importantly, no version numbers are part of the file names to gain long term stability. In case of version increments, "just" the versions coded in the file(s) need to be updated and (in some cases) new directories been created on grass.osgeo.org - see respective comments in the `cron_grass*.sh` files. Note: the redundancy in the files may be addressed by refactoring in a separate PR.

After merging of OSGeo#896 and cronjob deployment on grass.osgeo.org various issues came up which are addressed in this PR. Important: - fix incorrect branch in `cron_grass_new_current_build_binaries.sh` - generate programmer's manual only in `cron_grass_new_current_build_binaries.sh` Improvements: - fail early rather than useless continuation (`set -e`) - compile with 2 cores (`make -j2`) - fix copying of `INSTALL` and `REQUIREMENTS.html` to server download directory as being renamed to `INSTALL.md` and `REQUIREMENTS.md` - also copy `CITATION.cff` to server download directory Misc: - no longer generate gettext `.pot` file for transifex since we migrated to https://weblate.osgeo.org/projects/grass-gis/ (this PR potentially also addresses OSGeo#814)

neteler requested review from wenzeslaus and tmszi May 18, 2023 18:04

wenzeslaus requested changes May 18, 2023

View reviewed changes

wenzeslaus previously requested changes May 18, 2023

View reviewed changes

neteler closed this May 18, 2023

neteler reopened this May 23, 2023

make cronjob files versionless; update cron_job_list_grass; update RE…

15f4a5d

…ADME.md

neteler requested a review from wenzeslaus May 23, 2023 16:24

some header cleanup

da7d61e

remove file explanations

1a3d988

neteler merged commit f32aeb2 into OSGeo:grass8 May 29, 2023

neteler deleted the cronjob_update_new_versions_and_renaming branch May 29, 2023 09:59

neteler mentioned this pull request May 29, 2023

cronjobs: various fixes and cleanup #903

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cronjobs: new filename scheme and G84 added #896

cronjobs: new filename scheme and G84 added #896

neteler commented May 18, 2023 •

edited

Loading

wenzeslaus left a comment

ninsbl commented May 18, 2023

wenzeslaus May 18, 2023

neteler May 23, 2023 •

edited

Loading

wenzeslaus May 23, 2023

wenzeslaus May 18, 2023

neteler May 23, 2023

wenzeslaus May 23, 2023

neteler May 23, 2023

wenzeslaus May 23, 2023

neteler May 23, 2023

neteler commented May 18, 2023

neteler commented May 18, 2023

wenzeslaus commented May 19, 2023

neteler commented May 20, 2023

neteler commented May 23, 2023

wenzeslaus commented May 23, 2023 •

edited

Loading

wenzeslaus commented May 23, 2023

neteler commented May 25, 2023

		* grass8-old-current (current stable): `cron_grass8_old_current_src_snapshot.sh`
		* grass8-new-current (new stable): `cron_grass8_new_current_src_snapshot.sh`

cronjobs: new filename scheme and G84 added #896

cronjobs: new filename scheme and G84 added #896

Conversation

neteler commented May 18, 2023 • edited Loading

wenzeslaus left a comment

Choose a reason for hiding this comment

ninsbl commented May 18, 2023

Choose a reason for hiding this comment

neteler May 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neteler commented May 18, 2023

neteler commented May 18, 2023

wenzeslaus commented May 19, 2023

neteler commented May 20, 2023

neteler commented May 23, 2023

wenzeslaus commented May 23, 2023 • edited Loading

wenzeslaus commented May 23, 2023

neteler commented May 25, 2023

neteler commented May 18, 2023 •

edited

Loading

neteler May 23, 2023 •

edited

Loading

wenzeslaus commented May 23, 2023 •

edited

Loading