r.vif.py: add error message #942
Conversation
The error message given when one of the input layers has no values (within the computational region) does not help to understand the problem. Added an error message to suggest the possible cause of the error. Print error messages in color.
correct black and flake8 style issues
|
Here is some feedback about this: We try to make the behavior across the 800+ different tools in GRASS GIS standardized. This is adding two colors for messages which are not present in other tools. I'm all for colorful messages with message for an error and a hint/tip, but we need a more standardized approach which would be reusable in other tools. Having a PR adding your two functions to the library would be a good start. |
|
Hi @wenzeslaus , good point, didn't think about that. Wouldn't mind making such PR, but wouldn't know where to do that? |
|
The closest existing thing is grass.script.message and grass.script.fatal. They live in python/grass/script/core.py in the core repo. You can see from there that the Python side mostly relies on the g.message tool in C, but let's have that discussion in the PR. |
The error message given when one of the input layers has no values (within the computational region) does not help to understand the problem. Added an error message to suggest the possible cause of the error. Print error messages in color.
The error message given when one of the input layers has no values (within the computational region) does not help to understand the problem. Added an error message to suggest the possible cause of the error. On the command line, the error message is written in red.