-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass.jupyter: Add Query Button to InteractiveMap #3793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, I can't see any results for a vector map. Also, it behaves strangely, when I click first time, it works (for raster) and then when I click second time on the map, the output disappears. Does it behave the same for you?
It behaves like this: Recording.2024-06-11.230149.mp4 |
Even there you can see strange flashing around 13th second. I found out why I don't see any vector results, you don't set the threshold. https://github.com/OSGeo/grass/blob/main/gui/wxpython/mapdisp/frame.py#L1040 |
The main problem here is still the graphical representation of the results, it doesn't look very well. The css would have to be tweaked to make the table look nicer. @29riyasaxena Do you agree? Is that something you want to work on as part of this PR? Or we could leave that as separate PR. |
I think I can do this since it is not a difficult task. Also, I couldn't find the tests of |
https://github.com/OSGeo/grass/blob/main/python/grass/jupyter/testsuite/interactivemap_test.py |
Hi Anna, Thank you for providing the link. Running tests give me the following error: Could you please check what's going wrong here? |
It runs for me with this PR. How do you run the test? Is there any more output? |
Here's the complete output:
Is it because of wrong |
|
It's saying |
Running tests like this: |
Could you please try to address the code quality issues from the CI? |
It should also be with a merge from main into this branch, it is 189 commits behind, and LOTS have changed since, especially for Python |
To clarify this PR for others, could you please edit the description of this PR and include a brief summary and a most recent screenshot? |
Given #3838 is now merged, we need to make sure these modes (query, region) don't interact in a weird way. I think the toggle buttons should be exclusive, so when you toggle query button, the region button should untoggle (and hide region). There is ToggleButtons widget which does that, but probably more changes in the handling of both modes are needed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hello Everyone,
This pull request introduces a new feature to
grass.jupyter.interactivemap.py
: a query button that allows users to retrieve raster/vector information associated with a specific point.Here's how it operates:
For a visual demonstration, please refer to the following recording:
grass_query_button.mp4