Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.out.ogr: Fix exporting vector layers from a location whose CRS has no EPSG code #3869
base: main
Are you sure you want to change the base?
v.out.ogr: Fix exporting vector layers from a location whose CRS has no EPSG code #3869
Changes from all commits
5cffa26
47d256b
8da3982
88464da
36caea6
1cb6632
0b95ec4
08f7492
5a73b5f
35ba769
6bdc3c9
ebf444c
9b293b3
93f5429
280997f
a2ae200
fc2c253
1c83ffa
3235dfc
1c14af9
f98aead
3e80eca
d05b093
77fc48b
a076bbc
d1f70b7
6844064
16d61e0
b46fb05
1c96ce0
6fd87bc
f59f324
0bfb2ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a comment or two about why these two replace calls are needed. Are the characters an issue? Why are the characters there? How is the original GISDBASE working with them?
(Same for line 77.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those characters are included in the variable string, e.g.
'/home/lads/GRASSDATA';
. The tests do not fail if you don't remove them, however, the following call tormtree
then does not remove the actual temporary location. Garbage is thus left behind in the file system.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry to keep this hanging, but I find it both puzzling and concerning that GISDBASE retrieved by g.gisenv has quotes and a semicolon. Are you sure that's what you have there? Can you please directly run
g.gisenv
in the same or similar session you run the tests?And can you print from the test? (You may need to fail the test to get a print.)