wxGUI: Fixed F841 in ii2t_manager.py #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
requested changes
Sep 30, 2024
There was a problem hiding this comment.
See https://docs.wxpython.org/wx.BusyInfo.html to use BusyInfo with context manager
petrasovaa
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxed
F841by following changesbusyvariable and calling the function by itself since we don't need the return valuepointvariable which I assume was used to get cursor position but isn't used anywhere. I am not sure if this function has some inbuilt settings which are called with the constructor - in which case, we can just call it without getting the return valuesdiffandreload_target- which were just being reassigned without being used or passed on