Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Mobile Friendly Restyle #237

Merged
merged 85 commits into from
Sep 8, 2023
Merged

[PR] Mobile Friendly Restyle #237

merged 85 commits into from
Sep 8, 2023

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Aug 6, 2023

Issue for Context

#242

====
ORIGINAL COMMENT - References an approach I later abandoned, ignore

  • Seems to be responsive and form a hamburger
  • new linter and prettier scripts for auto format

next steps

  • actually reduce max width of screen on mobile, so that responsive navbar will be used
  • maybe hide left building filter menu by default on mobile?

http://energy-dashboard.s3-website-us-west-2.amazonaws.com/

Credit / Reference
https://nikakharebava.medium.com/responsive-navbar-menu-vuejs-da330526080e

@solderq35 solderq35 marked this pull request as draft August 6, 2023 09:25
@solderq35
Copy link
Contributor Author

may scale back the scope of this

  • keep viewport 1028px (or whatever) for mobile, too much work to rescale everything at present?
  • prioritize just making navbar responsive for resizing on desktop browser I guess
  • margin issue on all buildings page
  • look into options for mobile UI just for map page?
  • look into hiding left navbar for map on mobile

@solderq35
Copy link
Contributor Author

solderq35 commented Aug 7, 2023

may be better practice to separate linting and navbar fixes

make new PR with just linter / prettier update > now the navbar PR will be merged into updated formatted main branch

@solderq35
Copy link
Contributor Author

solderq35 commented Aug 7, 2023

look into css rules for first time? popup on mobile

  • consider just zooming out on graph, user will have to zoom out on mobile anyways

@solderq35
Copy link
Contributor Author

Progress

image

image

@solderq35 solderq35 marked this pull request as ready for review September 8, 2023 23:31
@solderq35 solderq35 merged commit 1bf6a19 into master Sep 8, 2023
3 checks passed
@solderq35 solderq35 changed the title [PR] Responsive Navbar Testing [PR] Mobile Friendly Restyle Sep 9, 2023
@s-egge s-egge deleted the responsive-navbar-testing branch July 1, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant