Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fix comparison graphs #253

Merged
merged 6 commits into from
Sep 9, 2023
Merged

[PR] Fix comparison graphs #253

merged 6 commits into from
Sep 9, 2023

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Sep 9, 2023

The comparison graphs didn't display correctly before, now they do.

Fixed background colors on comparison map popup, and slanted background pictures for the building comparison pages

@solderq35
Copy link
Contributor Author

@solderq35
Copy link
Contributor Author

@solderq35
Copy link
Contributor Author

used page ruler extension and increased width of the background image segments to cover gaps

@solderq35
Copy link
Contributor Author

There is still a console warning if you compare a building that has non-electricity data (e.g. solar or gas) to an electricity only building, and then refresh the "view full graph" page

Actually, the comparison only works for Electricity; if you try to include any building without Electricity in the comparison it will error out.

That probably should be handled with some user friendly error at some point

@solderq35
Copy link
Contributor Author

couldn't be bothered to properly display a warning for comparisons between incompatible buildings, but displayed info about how only electricity is valid on initial comparison prompt

@solderq35 solderq35 mentioned this pull request Sep 9, 2023
@solderq35 solderq35 merged commit f52b37c into master Sep 9, 2023
3 checks passed
@s-egge s-egge deleted the fix-comparison-graphs branch July 1, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant