Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned] multiple building category filter #266

Closed
wants to merge 3 commits into from

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Sep 16, 2023

Issue

#265

Changes so far

Map

SEC doesn't go away until you deselect both "Events and Admin" and "Solar"

Buildings Page

SEC now shows up on both Solar and Events and Admin tabs

The "all" tab luckily only shows one SEC, as intended

Next Steps

  • Mostly done feature wise, but need to think about how to represent multiple filters on the map. 2 colors?

@solderq35
Copy link
Contributor Author

solderq35 commented Sep 20, 2023

today's progress

image

Issues

new polygon with stripes. hardcoded polygon to center on OSU 35th St. Solar Array for testing.

new polygon doesn't go away on second click, need to fix. And customize triggers for state in general.

Implementation Logic Plan

selected group has a comma in it > both [0] and [1] of split string are present > stripes

one of [0] or [1] gone > remove stripe layer, see one color

both gone > nothing

Reference

@solderq35
Copy link
Contributor Author

Abandon this PR because it is starting to feel over-engineered.

If applicable, it would make more sense to create a secondary filter for electric / steam / gas / solar / etc than awkwardly support being able to support "events and admin" and "solar" (example).

Set SEC to "solar" group for now.

@solderq35 solderq35 closed this Sep 21, 2023
@solderq35 solderq35 changed the title [PR] multiple building category filter [Abandoned] multiple building category filter Sep 21, 2023
@s-egge s-egge deleted the multiple-building-filters branch July 1, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant