Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison menu cancel bug #281

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

s-egge
Copy link
Member

@s-egge s-egge commented Nov 25, 2023

Set building_compare_error to false in two places so that the modal will close if a building is clicked on or a new comparison is started.

Set building_compare_error to false in two places so that the modal will close if a building is clicked on or a new comparison is started.
@s-egge s-egge linked an issue Nov 25, 2023 that may be closed by this pull request
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@solderq35 solderq35 merged commit ada8fb7 into master Nov 27, 2023
3 checks passed
@s-egge s-egge deleted the fix-comparison-menu-cancel-bug branch July 1, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison Menu cancel menu bug
2 participants