Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] fix map search and geojson #289

Merged
merged 1 commit into from
Dec 31, 2023
Merged

[PR] fix map search and geojson #289

merged 1 commit into from
Dec 31, 2023

Conversation

solderq35
Copy link
Contributor

Fixed Issues

GeoJson issue: #274

  • Basically if you just click "All" and then "Electric" (alternate between them, do this like 4 times each), you get a console error eventually

Map Search: #288

  • I didn't notice this issue back when I reviewed a PR for it, so that's my bad

@solderq35 solderq35 changed the title fix map search and geojson [PR] fix map search and geojson Dec 30, 2023
@s-egge s-egge linked an issue Dec 31, 2023 that may be closed by this pull request
Map filter search issue on first load #288
Closed
@s-egge
Copy link
Member

s-egge commented Dec 31, 2023

I was able to confirm both the GeoJson and Map error on the main branch, but unable to replicate them after the fixes were implemented. There doesn't appear to be any unexpected behavior, the fix looks good.

@s-egge s-egge merged commit 5c20b19 into master Dec 31, 2023
3 checks passed
@s-egge s-egge deleted the fix-map-search-and-geojson branch July 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@s-egge s-egge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map filter search issue on first load
2 participants
@solderq35 @s-egge