-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pacific power meters #302
Conversation
UploadThe data upload for Pacific Power mimics the way that the Solar Meters are uploaded, and is differentiated by the DownloadThe We currently have a Download IssueThere is still an issue with the data on the front-end. It is being sent correctly from the back-end, but is incorrect after chart.module.js
calls postGetData:
TestingTo test, change this line to
|
DownloadThe bug above was because the The way that it's checked to be a Pacific Power meter may need work, as I wasn't able to check the meter itself but only the first meter in the meterGroup, but this is working as intended for the moment. The first image is with actual data from the database, there are days missing due to the webscraper not being automated to run daily right now, so the second picture has 30 days of daily dummy data to demonstrate the chart modifier is working as intended. UploadTo grab Pacific Power meter data, the download logic will first query the |
Added offset to make time of day consistent with other daily meters Rest of PR looks fine to me. I'm not sure why accumulated_real shows non-existent data as "zero" on the frontend (check Memorial Union), while energy_change just skips over the missing data point. But for now I don't think it's a big deal. |
Should be fine, I think it's safe to assume that all Pacific Power meters will not mix with other types of meters in a meter group. |
See OSU-Sustainability-Office/automated-jobs#21 (comment) I think the PR as it is now is good to go, but it might be a good idea to look into a better way of handling missing data (pacific power site doesn't show yesterday's data yet) in the future. |
No description provided.