Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pacific power meters to Meter class and API #333

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

s-egge
Copy link
Member

@s-egge s-egge commented May 28, 2024

Run the backend locally and go to http://localhost:3000/allbuildings to see the addition of pacificPowerID in the Meter class:

image

@s-egge s-egge marked this pull request as draft May 28, 2024 21:59
@s-egge
Copy link
Member Author

s-egge commented May 28, 2024

Updated Unit Tests

Previous tests failed due to the new pacific_power_id field. I've added this field to the test database, and all inserted meter data has the field as null since none of them are Pacific Power Meters.

@s-egge s-egge marked this pull request as ready for review May 28, 2024 22:15
@s-egge s-egge requested a review from solderq35 May 28, 2024 22:15
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For the backend/tests/assertedData/meters_insert.sql file, I wasn't sure if NULL vs null mattered, but I tested both in SQL workbench and capitalization doesn't seem to matter, so it's all good.

@solderq35 solderq35 linked an issue Jun 10, 2024 that may be closed by this pull request
@solderq35 solderq35 merged commit 4e27862 into master Jun 10, 2024
3 checks passed
@s-egge s-egge deleted the add-pp_meter_id-to-API branch July 1, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pacific_power_id to API meter / allBuildings endpoints?
2 participants