Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button refresh / deploy refresh automation #11

Merged
merged 13 commits into from
Apr 16, 2024

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Apr 14, 2024

Issue

#12

  • See stack overflow links in code comments for more technical details

Back Button Refresh (removed from latest commit)

Deploy Automation Refresh

  • Demo: https://i.imgur.com/cinjAbQ.mp4
  • As specified in the code, this is supposed to refresh whenever the "last modified" header changes
    • Currently re-checking every 10 minutes, but you can set refreshInterval to be 20 seconds for testing
    • Fetch requests seem to always return status 200 and "last modified" (therefore that's the only header checked for in this PR). If manually visiting a website in your browser and checking Inspect Element > Network, then a return status of 304 might show "If-Modified-Since" header instead
  • Based on previous testing, it is not actually necessary to change any files to get the refresh to work, just re-run the page build process.
    • image
    • image

TODO

  • Further testing on any bugs etc (for quick testing, can lower refreshInterval from 10 minutes to something like 20 seconds. Make sure to have the page (http://sustainability-kiosks.s3-website-us-west-2.amazonaws.com/) open in web browser already before triggering a new deploy
  • Verify this actually works on the actual kiosks or not
  • Remove some of the log statements as specified by TODO code comments
  • Remove hiring page from the main index (src/router/index.js) after April 14
  • One of the TODO code comments about font URL prefixes can be ignored, as it is not a huge issue and can probably be moved to another PR (Fix Font issue #3)

@solderq35 solderq35 linked an issue Apr 14, 2024 that may be closed by this pull request
@solderq35 solderq35 marked this pull request as ready for review April 15, 2024 02:26
@solderq35 solderq35 requested a review from s-egge April 15, 2024 02:27
@@ -16,14 +16,14 @@
<el-col class="sus-title"> Sustainability at OSU is hiring!</el-col>
</el-row>
<el-row class="sus-hiring-info">
<el-col span="12">
<el-col :span="12">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were changed due to a type error warning

@solderq35
Copy link
Contributor Author

Might remove the back button feature but keep the refresh on deploy feature

@s-egge s-egge merged commit 48474f7 into master Apr 16, 2024
1 check passed
@s-egge s-egge deleted the refresh-back-button-deploy branch July 1, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiosk Refreshing upon New Changes
2 participants