Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing storageClassName definition #179

Closed
wants to merge 4 commits into from
Closed

Add missing storageClassName definition #179

wants to merge 4 commits into from

Conversation

apena-pmy
Copy link

Add missing storageClassName definition for storageSpec.nodeConfVolumeClaimTemplate

apena-pmy and others added 4 commits December 7, 2023 10:28
Add storageClassName to nodeConfVolumeClaimTemplate

Signed-off-by: Alejandro Peña <apena@matriz.com.ar>
Signed-off-by: Alejandro Peña <apena@matriz.com.ar>
Signed-off-by: Alejandro Peña <apena@matriz.com.ar>
Copy link

gitguardian bot commented Aug 30, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13074003 Triggered Generic Password d3608f6 charts/pga/examples/thanos/values.yaml View secret
13074003 Triggered Generic Password d3608f6 charts/pga/examples/thanos/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@apena-pmy apena-pmy closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant