Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod Affinity #224

Closed
wants to merge 17 commits into from
Closed

pod Affinity #224

wants to merge 17 commits into from

Conversation

khushimalhoz
Copy link
Contributor

pod affinity

@khushimalhoz khushimalhoz self-assigned this Jul 29, 2024
@@ -112,12 +112,29 @@ deployment:

tolerations: []

affinity: {}
affinity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this setting as default in the deployment helm template. If someone wants to override the default setting, he can use these parameters to override.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the changes
To make the affinity and tolerations
in deployment.yaml
affinity:
{{- toYaml (merge .Values.deployment.affinity (default dict .Values.deployment.affinity)) | nindent 8 }}
tolerations:
{{- toYaml (merge .Values.deployment.tolerations (default dict .Values.deployment.tolerations)) | nindent 8 }}

affinity and tolerations settings have default values defined in values.yaml, and these settings can be overridden by user-specified values. The merge function combines the defaults with the user-provided values, ensuring that the user can override the default settings if needed.

@@ -1,5 +1,6 @@
global:
namespace: "demo-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not update this file. Please create new as example values yaml how we can use the affinity and topoloty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have created a affinity.yaml file in examples directory.

@ashwani-opstree
Copy link
Contributor

Please check why these pipeline checks are failing

@khushimalhoz
Copy link
Contributor Author

Please check why these pipeline checks are failing
Regarding the checks which are failing
image
I cannot add DOC to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants