Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Percona MongoDB helm chart with backup support #230

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

tarunsinghot
Copy link
Contributor

No description provided.

alias: psmdb-db
tags:
- psmdb-db
condition: psmdb-db.enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of line needs to be added in all files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added end of line in all files.

spec:
clusterName: mdb-db-psmdb-db
storageName: azure-blob
type: logical
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is hardcoded, why are we not using templates here?

Copy link
Contributor Author

@tarunsinghot tarunsinghot Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added file as a template.

name: restore1
spec:
clusterName: mdb-db-psmdb-db
backupName: backup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is hardcoded, why are we not using templates here?

Copy link
Contributor Author

@tarunsinghot tarunsinghot Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added file as a template.

# memory: "0.5G"
# requests:
# cpu: "300m"
# memory: "0.5G"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add all possible options here in the commented code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added all the possible options for the values file.

@iamabhishek-dubey iamabhishek-dubey changed the title Percona MongoDB Added Percona MongoDB helm chart with backup support Dec 13, 2024
charts/psmdb-operator-db/templates/backup.yaml Outdated Show resolved Hide resolved
charts/psmdb-operator-db/templates/backup.yaml Outdated Show resolved Hide resolved
affinity: {}

logStructured: false
logLevel: "INFO"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add additional line along with comment that this is for psmdb-db

@iamabhishek-dubey iamabhishek-dubey merged commit 03d5a2d into main Dec 13, 2024
2 of 5 checks passed
@iamabhishek-dubey iamabhishek-dubey deleted the percona-mongodb branch December 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants