-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Percona MongoDB helm chart with backup support #230
Conversation
charts/psmdb-operator-db/Chart.yaml
Outdated
alias: psmdb-db | ||
tags: | ||
- psmdb-db | ||
condition: psmdb-db.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End of line needs to be added in all files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added end of line in all files.
charts/psmdb-operator-db/backup.yaml
Outdated
spec: | ||
clusterName: mdb-db-psmdb-db | ||
storageName: azure-blob | ||
type: logical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File is hardcoded, why are we not using templates here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added file as a template.
name: restore1 | ||
spec: | ||
clusterName: mdb-db-psmdb-db | ||
backupName: backup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File is hardcoded, why are we not using templates here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added file as a template.
charts/psmdb-operator-db/values.yaml
Outdated
# memory: "0.5G" | ||
# requests: | ||
# cpu: "300m" | ||
# memory: "0.5G" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add all possible options here in the commented code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added all the possible options for the values file.
affinity: {} | ||
|
||
logStructured: false | ||
logLevel: "INFO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add additional line along with comment that this is for psmdb-db
No description provided.