draft: untangling the buses #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the gui should not attempt to launch mycroft
remove unused listeners / workarounds classic core, keep message.context unconditionally the "hivemind" integration here has nothing to do with hivemind, just native message.context settings it to mycroft-gui instead of pretending to be the debug cli if utterances from gui should be spoken and not treated as a different client this should instead by added to native_sources in mycroft.conf remove android specific remote-tts bus messages, these are not standardized and if implemented should use the native ovos bus events, currently tied to undocumented / not included code, this one really needs to use hivemind when implemented back, before that connections to core bus will have to be removed and this refactored to use only the gui bus
JarbasAl
force-pushed
the
simplify-core-bus-messages
branch
from
a1e5a07
to
761e834
Compare
keep removing android stuff to simplify the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unused listeners / workarounds classic core, keep message.context unconditionally
the "hivemind" integration here has nothing to do with hivemind, just native message.context settings it to mycroft-gui instead of pretending to be the debug cli
if utterances from gui should be spoken and not treated as a different client this should instead by added to native_sources in mycroft.conf
remove android specific remote-tts bus messages, these are not standardized and if implemented should use the native ovos bus events, currently tied to undocumented / not included code, this one really needs to use hivemind when implemented back, before that connections to core bus will have to be removed and this refactored to use only the gui bus
remove logic that launches or depends on specific skills
remove android support completely (that's worth it's own repo instead of a lot of ifdefs)