Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#684): add DAST with ZAP #705

Merged
merged 11 commits into from
Mar 15, 2023
Merged

feat(#684): add DAST with ZAP #705

merged 11 commits into from
Mar 15, 2023

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented Mar 13, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

This PR adds a workflow to run the baseline scan against WrongSecrets running on Kubernetes. It will open and update a GitHub issue with potential problems.

Relations

Closes #684

References

Implemented the action according to OWASP ZAP baseline scan action documentation

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

@bendehaan bendehaan marked this pull request as draft March 13, 2023 16:03
@bendehaan bendehaan marked this pull request as ready for review March 13, 2023 16:33
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lgtm! Can you please file an issue for the remaining findings :-)?

@bendehaan
Copy link
Collaborator Author

Thanks! Lgtm! Can you please file an issue for the remaining findings :-)?

Will do!

@bendehaan
Copy link
Collaborator Author

Opened #709

@commjoen commjoen merged commit 9a4845d into master Mar 15, 2023
@commjoen commjoen deleted the feat/dast branch March 15, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add DAST (ZAP) via github action
2 participants