OXDEV-7647: Move some exception-annotations to the original methods

OXID-eSales · Dec 6, 2023 · 4d22a2d · 4d22a2d
1 parent e78f9d0
commit 4d22a2d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Setting/Infrastructure/ShopSettingRepository.php b/src/Setting/Infrastructure/ShopSettingRepository.php
@@ -207,9 +207,6 @@ public function saveAssocCollectionSetting(string $name, array $value): void
         $this->saveAsType(FieldType::ASSOCIATIVE_ARRAY, $name, $value);
     }
 
-    /**
-     * @throws WrongSettingTypeException
-     */
     private function saveAsType(string $type, string $name, mixed $value): void
     {
         $this->validateOriginalSettingType($name, $type);
@@ -223,6 +220,9 @@ private function saveAsType(string $type, string $name, mixed $value): void
         $this->configurationSettingDao->save($setting);
     }
 
+    /**
+     * @throws WrongSettingTypeException
+     */
     private function validateOriginalSettingType(string $originalSettingName, string $type): void
     {
         $originalSetting = $this->getShopSetting($originalSettingName);

diff --git a/src/Setting/Infrastructure/ThemeSettingRepository.php b/src/Setting/Infrastructure/ThemeSettingRepository.php
@@ -184,6 +184,9 @@ public function saveAssocCollectionSetting(string $name, array $value, string $t
         $this->saveSettingAsType(FieldType::ASSOCIATIVE_ARRAY, $name, $themeId, $value);
     }
 
+    /**
+     * @throws NoSettingsFoundForThemeException
+     */
     protected function getSettingValue(string $name, string $fieldType, string $theme): mixed
     {
         $queryBuilder = $this->queryBuilderFactory->create();
@@ -240,9 +243,6 @@ protected function saveSettingValue(string $name, string $themeId, string $value
         );
     }
 
-    /**
-     * @throws NoSettingsFoundForThemeException
-     */
     protected function saveSettingAsType(string $settingType, string $name, string $themeId, mixed $value): void
     {
         $this->getSettingValue($name, $settingType, $themeId);