OXDEV-7325: Correct test names and add type hints; Remove unnecessary…

… usages;
OXID-eSales · Dec 6, 2023 · d6caf99 · d6caf99
1 parent c5c0e3d
commit d6caf99
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/tests/Unit/Infrastructure/ThemeSettingRepositoryGettersTest.php b/tests/Unit/Infrastructure/ThemeSettingRepositoryGettersTest.php
@@ -29,7 +29,7 @@ class ThemeSettingRepositoryGettersTest extends AbstractThemeSettingRepositoryTe
      * @dataProvider possibleGetCollectionValuesDataProvider
      * @dataProvider possibleGetAssocCollectionValuesDataProvider
      */
-    public function testGetShopSetting($method, $type, $possibleValue, $expectedResult): void
+    public function testGetThemeSetting(string $method, string $type, mixed $possibleValue, mixed $expectedResult): void
     {
         $name = uniqid();
         $sut = $this->getSut(methods: ['getSettingValue']);
@@ -45,10 +45,10 @@ public function testGetShopSetting($method, $type, $possibleValue, $expectedResu
     /**
      * @dataProvider wrongSettingsValueDataProvider
      */
-    public function testGetShopSettingWrongData(
+    public function testGetThemeSettingWrongData(
         string $method,
         string $type,
-        $value,
+        mixed $value,
         string $expectedException
     ): void {
         $name = uniqid();

diff --git a/tests/Unit/UnitTestCase.php b/tests/Unit/UnitTestCase.php
@@ -10,15 +10,10 @@
 namespace OxidEsales\GraphQL\ConfigurationAccess\Tests\Unit;
 
 use OxidEsales\EshopCommunity\Internal\Transition\Utility\BasicContextInterface;
-use OxidEsales\GraphQL\ConfigurationAccess\Setting\DataType\BooleanSetting;
-use OxidEsales\GraphQL\ConfigurationAccess\Setting\DataType\FloatSetting;
-use OxidEsales\GraphQL\ConfigurationAccess\Setting\DataType\IntegerSetting;
 use OxidEsales\GraphQL\ConfigurationAccess\Setting\DataType\SettingType;
-use OxidEsales\GraphQL\ConfigurationAccess\Setting\DataType\StringSetting;
 use OxidEsales\GraphQL\ConfigurationAccess\Setting\Enum\FieldType;
 use OxidEsales\GraphQL\ConfigurationAccess\Setting\Service\CollectionEncodingServiceInterface;
 use PHPUnit\Framework\TestCase;
-use TheCodingMachine\GraphQLite\Types\ID;
 
 class UnitTestCase extends TestCase
 {