OXDEV-8952: Remove BeforeModuleDeactivation because it's handled by shop

OXID-eSales · Jan 3, 2025 · d8a3bca · d8a3bca
1 parent 91f5515
commit d8a3bca
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 112 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Move ModuleDataType generation to Infrastructure
 - Move ThemeDataType generation to Infrastructure
 
+### Removed
+- `OxidEsales\GraphQL\ConfigurationAccess\Shared\Subscriber\BeforeModuleDeactivation` because de/activation is already handled by shop
+
 ## [1.2.0] - 2024-11-27
 This is the stable release of v1.2.0. No changes have been made since v1.2.0-rc.1.
 

diff --git a/services.yaml b/services.yaml
@@ -4,9 +4,6 @@ imports:
   - { resource: src/Shop/services.yaml }
   - { resource: src/Theme/services.yaml }
 
-parameters:
-  oxidesales.graphqlconfigurationaccess.depends_on_modules: [ 'oe_graphql_base' ]
-
 services:
 
   _defaults:
@@ -24,10 +21,3 @@ services:
   OxidEsales\GraphQL\ConfigurationAccess\DependencyCheckTrigger:
     alias: OxidEsales\GraphQL\Base\Framework\GraphQLQueryHandler
     public: true
-
-  OxidEsales\GraphQL\ConfigurationAccess\Shared\Subscriber\BeforeModuleDeactivation:
-    class: OxidEsales\GraphQL\ConfigurationAccess\Shared\Subscriber\BeforeModuleDeactivation
-    arguments:
-      $dependencies: '%oxidesales.graphqlconfigurationaccess.depends_on_modules%'
-    tags: [ 'kernel.event_subscriber' ]
-    public: true
diff --git a/src/Shared/Subscriber/BeforeModuleDeactivation.php b/src/Shared/Subscriber/BeforeModuleDeactivation.php
diff --git a/tests/Unit/Shared/Subscriber/BeforeModuleDeactivationTest.php b/tests/Unit/Shared/Subscriber/BeforeModuleDeactivationTest.php