Automatic display of values in Imperial/International system #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "unit system" uses the correct system based on the options. It either displays values in the Imperial system (default) or in the International system. The PC creation phase has been adapted to use this feature.
Replaced written occurrences of inch(es) and foot/feet to use the Unit System instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to change the system of units displayed in the interface with the toggle of an option (for some parts of the game).
A new option to change between the imperial and International system has been added. Its default state is for the use of the imperial system (inches, feet, pounds, ...) and once toggled the values displayed to the user are in the International System (centimeters, meters, grams, kilograms, liter, ...).
A new class is in charge of displaying values in the correct system of units [
classes/Units/UnitSystem.as].As a first step towards complete adaptation, a few scripts have been change to use the automatic conversion of units :
includes/creation.as]includes/creation.as]includes/gameStats.as]Some sort of conversion was already in place for the personal statistics, but it has been supplanted by the new system.
The next step would be to adapt the rest of the project to use the unit system manager.