Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert fl changes #712

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: revert fl changes #712

merged 2 commits into from
Nov 15, 2024

Conversation

halaprix
Copy link
Member

Ticket URL

[Link to ticket]

Description of Changes

This PR reverts recent changes to flashloan handling in Aave-like strategies:

  • Reverts condition for flashloan fee handling back to Spark-only check
  • Removes L2 non-Maker flashloan provider logic
  • Bumps dma-library version from 0.6.78 to 0.6.79

How to Test

  1. Test Aave-like multiply strategy adjustments:
    • Verify flashloan fee handling works correctly for Spark protocol
    • Confirm DssFlash provider works as expected
  2. Test Aave-like close operations:
    • Verify flashloan calculations are correct
    • Ensure debt balance interest accrual is handled properly

PR Definition of Done

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted
  • Documentation has been updated if necessary

@halaprix halaprix merged commit 57668db into dev Nov 15, 2024
2 checks passed
@halaprix halaprix deleted the kk/revert-fl-changes branch November 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants