Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parcels versioning/deprecation policies and maintainer docs #1696

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Sep 10, 2024

Fixes #1681, fixes #1688 and other minor changes

New pages:

Note that this PR specifies

Parcels, as of v3.1.0, has adopted versioning and deprecation policies.

indicating that the next release of Parcels will be v3.1.0. Even if we don't add any new features, the deprecation policy mentions that deprecations are done between minor releases (e.g., v3.x.0) while patch releases (e.g., v3.0.x) are reserved for minor changes like bug fixes or usability improvements.

In terms of organisation, Sphinx works better with a directory layout (as opposed to a flat layout with individual pages, which is what we currently have). The dir layout allows Sphinx to better build the toc trees, which I think is better for the longterm. As such, this PR will change the link to our contributing guidelines and go from .../latest/contributing.html to .../latest/community/contributing.html. I have added a redirect so users with the old link /latest/contributing.html go to the updated page.

I have also updated RTD to now point back to latest instead of the tagged release.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1696   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files          72       72           
  Lines       13256    13256           
  Branches      127      127           
=======================================
  Hits        10762    10762           
  Misses       2457     2457           
  Partials       37       37           
Flag Coverage Δ
integration-tests 64.83% <ø> (ø)
mypy 15.65% <ø> (ø)
unit-tests 81.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

- create community index page
- add policy docs
- update contributing page
- add maintainer notes
@VeckoTheGecko
Copy link
Contributor Author

VeckoTheGecko commented Sep 10, 2024

I'm also finding the coverage bot comments on every PR slightly annoying. Perhaps worth disabling? Other projects have the bot texting in a Gitter/Slack channel (which we don't have, and they don't support teams). I don't mind just checking the codecov page directly

@erikvansebille
Copy link
Member

I'm also finding the coverage bot comments on every PR slightly annoying. Perhaps worth disabling? Other projects have the bot texting in a Gitter/Slack channel (which we don't have, and they don't support teams). I don't mind just checking the codecov page directly

Yes agree that we don't need codecov messages in each PR

docs/community/maintainer.md Outdated Show resolved Hide resolved
docs/community/maintainer.md Outdated Show resolved Hide resolved
docs/community/policies.md Outdated Show resolved Hide resolved
docs/installation.rst Show resolved Hide resolved
docs/community/contributing.rst Outdated Show resolved Hide resolved
@VeckoTheGecko VeckoTheGecko merged commit d4d35c1 into master Sep 11, 2024
13 checks passed
@VeckoTheGecko VeckoTheGecko deleted the v/docs branch September 11, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Maintainer documentation Parcels versioning and deprecation policy
2 participants