Cleanup macOS debugging files #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
commented
Nov 29, 2024
VeckoTheGecko
force-pushed
the
v/1637
branch
from
91e3bbe to
d29ef51
Compare
`basename` is never a collection. It is always a string
dyn_srcs is not used in the codebase as its never defined (also backed up by having no test coverage), leading to several cleanups.
Still need to add tests, and make sure that no other places are saving these debugging files. xref #1637
VeckoTheGecko
force-pushed
the
v/1637
branch
from
d29ef51 to
df1b0a0
Compare
VeckoTheGecko
commented
Nov 29, 2024
erikvansebille
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files of
.so.dSYM extensionare debugging files creating during C compilation on MacOS systems. This PR checks for them and cleans them up if they exist. This PR also does some refactoring of dead code related toKernel.dyn_srcs.During my debugging in a Jupyter notebook, I did realise some erroneous
.sofiles were left behind sometimes. A bit inconsistent, as these should have been garbage collected. Couldn't recreate in the tests though. Perhaps something to do with the Jupyter notebook environment and how items are garbage collected? Thoughts @erikvansebille ?Fixes #1637