feat(other): major improvement of deployment #7925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
hetzner
branch
3 times, most recently
from
22e9342
to
92cf050
Compare
Tirokk
changed the title
Tirokk
changed the title
14 tasks
Tirokk
requested changes
Oct 10, 2024
Comment on lines
18
to
19
| CATEGORIES_ACTIVE: | ||
| webapp: |
There was a problem hiding this comment.
Have an empty line here?
Suggested change
| CATEGORIES_ACTIVE: | |
| webapp: | |
| CATEGORIES_ACTIVE: | |
| webapp: |
| NEO4J_dbms_memory_heap_max__size: "" | ||
| NEO4J_dbms_memory_pagecache_size: "" | ||
| NEO4J_dbms_security_procedures_unrestricted: "algo.*,apoc.*" | ||
| NEO4J_dbms_default__database: |
There was a problem hiding this comment.
Should we just set the default name here?
Because then it's clarified what it is …
Suggested change
| NEO4J_dbms_default__database: | |
| NEO4J_dbms_default__database: "neo4j" |
roschaefer
force-pushed
the
hetzner
branch
8 times, most recently
from
d146e16
to
c3b5f96
Compare
roschaefer
force-pushed
the
hetzner
branch
5 times, most recently
from
2f9bfce
to
9a268cd
Compare
Motivation ---------- Kubernetes: * backend becomes a statefulset (exclusive volume mount) See: https://spacelift.io/blog/statefulset-vs-deployment * implement neo4j backup with job Docker: * consistent targets across all dockerfiles * remove redundant labels * remove unnecessary build args * remove obsolete networks * remove development dependencies for production Rebranding: * add image tags for local tagging and pulling * use Github's docker build workflows * use Github container registry * ONBUILD to simplify caller Dockerfiles * docker compose for branding Tooling: * same node --version as in dockerfile Docs: * missing step in README.md
roschaefer
changed the title
It's better to keep them all in a separate repository
* better image tag defaults * split neo4j into its own chart (for re-use) * use application defaults where possible
and add labels for neo4j enterprise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Kubernetes:
See: https://spacelift.io/blog/statefulset-vs-deployment
Docker:
Rebranding:
Tooling:
Docs: