Publish: attempt to handle replay name-clash failures #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue > Did get a complaint from a user who was unable to edit his livestream placeholder to a replay. It would tell him he has a duplicate claim, so it was sending a stream create vs an edit. Trying to repro how they are getting into that scenario, works normally for us otherwise. ## Possible Root Wasn't able to replicate, but if the issue is about `stream_create` vs. `stream_update`, then that narrows it down to a missing `claim_id` when creating the payload. The use of `selectMyClaimForUri` to get the claim-being-edited has always been sketchy, since that depends network fetches and a ton of logic. Most likely it returned undefined here. ## Change With recent changes, we are now storing `claimToEdit` in Redux and persisting it over F5. That object is guaranteed to be populated first before entering Edit stage, so derivation isn't necessary anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
inf, or maybe wait for actual repro steps.Issue
Possible Root
Wasn't able to replicate, but if the issue is about
stream_createvs.stream_update, then that narrows it down to a missingclaim_idwhen creating the payload.The use of
selectMyClaimForUrito get the claim-being-edited has always been sketchy, since that depends network fetches and a ton of logic. Most likely it returned undefined here.Change
With recent changes, we are now storing
claimToEditin Redux and persisting it over F5. That object is guaranteed to be populated first before entering Edit stage, so derivation isn't necessary anymore. This should cross out a possible path for failure.