Livestreams: fixes related to 'excludedChannelIds' #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top loop must have come from experimentation when moving the filter from a selector to a util-function. It does a subset of the bottom loop, and would have included duplicates if `excludedChannelIds` was provided.
infinite-persistence
added a commit
that referenced
this pull request
Aug 23, 2023
infinite-persistence
force-pushed
the
live.not
branch
from
682bc14
to
7f9a1c8
Compare
Closes 2933
infinite-persistence
force-pushed
the
live.not
branch
from
7f9a1c8
to
aa21742
Compare
infinite-persistence
changed the title
infinite-persistence
added a commit
that referenced
this pull request
Aug 23, 2023
Closes 2933 ## Issue - CategoryPage was still using the old selector instead of `filterActiveLivestreamUris()`, which contains a prior fix. - The old selector logic assumes an "either or" of the whitelist/blacklist, but in reality both can be given. ## Change - Sync up the selector to do an "AND", where the blacklist works on top of the whitelist. - Doing the fix directly for now ... can DRY it up later.
infinite-persistence
force-pushed
the
live.not
branch
from
aa21742
to
7c5ae8c
Compare
infinite-persistence
added a commit
that referenced
this pull request
Aug 23, 2023
Message from Tom: > use excluded on both livestream and regular content sections. If not wild west, don't use exluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2933
Test:
inf