Fix missing resolve for purchase receipt #2939
Merged
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce
Root
We used to always call
resolve + include_purchase_receipt
when entering a File Page. The embed/hoc refactoring skips that if the claim is already in cache, but that claim was resolved withoutinclude_purchase_receipt
from step 2's search.Change
Retain existing optimization, but also double-check if the claim requires a fee. If yes, then re-fetch if we don't have the purchase receipt info.