Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing resolve for purchase receipt #2939

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

infinite-persistence
Copy link
Collaborator

Reproduce

  1. F5 to clear resolve cache.
  2. Navigate to a channel that you have purchased something from.
  3. Click on the claim that you know you have purchased. The app still asks you to purchase it.

Root

We used to always call resolve + include_purchase_receipt when entering a File Page. The embed/hoc refactoring skips that if the claim is already in cache, but that claim was resolved without include_purchase_receipt from step 2's search.

Change

Retain existing optimization, but also double-check if the claim requires a fee. If yes, then re-fetch if we don't have the purchase receipt info.

## Reproduce
1. F5 to clear resolve cache.
2. Navigate to a channel that you have purchased something from.
3. Click on the claim that you know you have purchased. The app still asks you to purchase it.

## Root
We used to always call `resolve + include_purchase_receipt` when entering a File Page.
The embed/hoc refactoring skips that if the claim is already in cache, but that claim was resolved without `include_purchase_receipt` from step 2's search.

## Change
Retain existing optimization, but also double-check if the claim requires a fee. If yes, then re-fetch if we don't have the purchase receipt info.
@infinite-persistence infinite-persistence merged commit 99ff8f0 into master Aug 24, 2023
2 checks passed
@infinite-persistence infinite-persistence deleted the missing.purchase branch August 24, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant