Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButtonPurchase: handle auth and insufficient funds #2945

Merged
merged 2 commits into from
Aug 29, 2023
Merged

ButtonPurchase: handle auth and insufficient funds #2945

merged 2 commits into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. ButtonPurchase: add auth requirement 

    Ticket: 2943

The existing error message does say "authentication required", though.  I guess that's too technical.
    @infinite-persistence
    infinite-persistence committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0e0e06f View commit details
    Browse the repository at this point in the history

  2. LBC Purchase Modal: repeat fund check instead of failing silently 

    ## Issue
The purchase button invokes the modal, and the modal just fails silently when there's insufficient funds.

## Change
I believe we used to show the button differently when the funds are insufficient (grayed out?).

Given the purchase button + claim overlay refactoring, it's probably easier now to just let the user click the button, and inform in the modal if there's insufficient funds. The file page already have the same "insufficient fund" warning.
    @infinite-persistence
    infinite-persistence committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2e0c400 View commit details
    Browse the repository at this point in the history