Following: handle removed channels better #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue If your subscriptions contain deleted channels, the app continuously resolves it on every page navigation. ## Why 2549 resolves all subs at startup, but it was done inside a component that gets remounted on every navigation. Even if there the sub list is clean, we still end up having to loop the resolve cache to see if the subs are resolved. ## Fix There is a dedicated place for these one-item post-startup actions, so let's move business logic away from Views.
This can be argued both ways I guess -- never show them, or allow users to decide what to do with it. For me, it's nice to be able to see past subs being deleted.
infinite-persistence
force-pushed
the
handle.deleted.channels
branch
from
8a4123a
to
5a4f846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2132
Test:
infBehavioral changes
Internal changes