Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumpy progress nub in Safari #3000

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix jumpy progress nub in Safari #3000

merged 1 commit into from
Oct 17, 2023

Conversation

infinite-persistence
Copy link
Collaborator

Patches 448d0b6

Symptom

The left: npx was incrementing correctly, but visually the nub goes backwards on every pixel step.

Might be due to a recent change in Safari -- somewhat sure the previous commit was tested on Safari back then.

Patches 448d0b6

## Symptom
The `left: npx` was incrementing correctly, but visually the nub goes backwards on every pixel step.

Might be due to a recent change in Safari -- somewhat sure the previous commit was tested on Safari back then.
Copy link
Contributor

@toshokanneko toshokanneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to use BrowserStack in order to test it so I'm just gonna assume that you've already done that and that it works. From a technical perspective, using translateX(-50%) instead seems fine.

@infinite-persistence infinite-persistence merged commit 4659604 into master Oct 17, 2023
2 checks passed
@infinite-persistence infinite-persistence deleted the safari.nubby branch October 17, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants