Add ability for methods to skip the artificial timeout #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9b44b7e, we added an artificial fetch timeout that's shorter than the browser's default so that (1) user don't have to wait too long (2) we get to differentiate the error as being a timeout (fetch errors all use the same string). This commit provides the ability to specify list of methods that will bypass that mechanism (i.e. use browser's default timeout length).
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9b44b7e, we added an artificial fetch timeout that's shorter than the browser's default so that (1) user don't have to wait too long (2) we get to differentiate the error as being a timeout (fetch errors all use the same string).
This commit provides the ability to specify list of methods that will bypass that mechanism (i.e. use browser's default timeout length. I think Firefox was like 90s), with
txo_listbeing the first (known to be long, should just wait for it)Test:
kp