chore: Update dependencies and add Supplier email and phone fields #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the dependencies in the package.json file of the msgext-northwind-inventory-ts sample. It adds the following dependencies: - @azure-rest/communication-messages@1.0.1 - @azure/communication-email@1.0.0 - @azure/communication-sms@1.1.0 - @azure/core-auth@1.6.0 Additionally, it modifies the model.ts file to include the SupplierEmail and SupplierPhone fields in the ProductEx interface. This allows for storing and retrieving the email and phone information of suppliers. These changes were made to improve the functionality and data representation of the Northwind Inventory sample.
|
Thank you for your PR @MilanKaur-01 👏 @BobGerman @rabwill would you be able to review? |
|
@garrytrinder and @BobGerman Is it more logical to keep the ACS sample as a separate sample, rather than merging it with the existing NW bot, which might be a simpler starting point for beginners? |
|
@rabwill I think that's a sensible idea. |
|
+1 - I think it should be a separate sample - this sample has become popular on its own and though I love ACS I don't want to add the dependencies for the basic scenario... @MilanKaur-01 do you mind making a new sample here? Like - copy the whole project to a new folder such as "msgext-northwind-inventory-with-acs" and make a new PR? Thanks! |
|
[like] Milan Kaur reacted to your message:
…________________________________
From: Bob German ***@***.***>
Sent: Friday, May 31, 2024 4:03:39 PM
To: OfficeDev/Copilot-for-M365-Plugins-Samples ***@***.***>
Cc: Milan Kaur ***@***.***>; Mention ***@***.***>
Subject: Re: [OfficeDev/Copilot-for-M365-Plugins-Samples] chore: Update dependencies and add Supplier email and phone fields (PR #117)
+1 - I think it should be a separate sample - this sample has become popular on its own and though I love ACS I don't want to add the dependencies for the basic scenario...
@MilanKaur-01<https://github.com/MilanKaur-01> do you mind making a new sample here? Like - copy the whole project to a new folder such as "msgext-northwind-inventory-with-acs" and make a new PR?
—
Reply to this email directly, view it on GitHub<#117 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5VES6GGCYPEIIFLKBM6NZDZFCNNXAVCNFSM6AAAAABH6WUHJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSGU3DAMBRGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the dependencies in the package.json file of the msgext-northwind-inventory-ts sample. It adds the following dependencies:
Additionally, it modifies the model.ts file to include the SupplierEmail and SupplierPhone fields in the ProductEx interface. This allows for storing and retrieving the email and phone information of suppliers.
These changes were made to improve the functionality and data representation of the Northwind Inventory sample.