Updating new sample - msgext-northwind-inventory-csharp #143
Conversation
…adeesh-MSFT/Copilot-for-M365-Samples into v-jegadeesh/northwind-csharp
samples/msgext-northwind-inventory-csharp/MessageExtensions/DiscountedSearchCommand.cs
Outdated
Show resolved
Hide resolved
samples/msgext-northwind-inventory-csharp/MessageExtensions/productSearchCommand.cs
Outdated
Show resolved
Hide resolved
samples/msgext-northwind-inventory-csharp/AdaptiveCards/successCard.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you for your PR @Jegadeesh-MSFT, I've left a few comments, let's get these addressed and I'll give it another pass.
I noticed an error on the adaptive card when added to a message in Teams.
I wasn't able to test this in Copilot as the tenant I am using is having issues so that is an outstanding task for me to complete.
| { | ||
| "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.16/MicrosoftTeams.schema.json", | ||
| "manifestVersion": "1.16", | ||
| "version": "1.0.9", |
There was a problem hiding this comment.
Let's make this 1.0.0 to reflect that this is the first version of the sample.
|
|
||
| Version|Manifest version|Date|Author|Comments | ||
| -------|--|--|----|-------- | ||
| 1.0|1.16|November 15, 2023 |Jegadeesh V <br/> Wajeed Shaikh|Initial release for Csharp labs |
There was a problem hiding this comment.
Let's update the table to make it up to date:
- update the version column should match the version in the manifest, ideally,
1.0.0 - update the date to the current date
| - [Azure subscription](https://portal.azure.com) | ||
| - [Teams Toolkit for Visual Studio](https://learn.microsoft.com/en-us/microsoftteams/platform/toolkit/toolkit-v4/install-teams-toolkit-vs?pivots=visual-studio-v17-7) | ||
| - You will need a Microsoft work or school account with [permissions to upload custom Teams applications](https://learn.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading). The account will also need a Microsoft Copilot for Microsoft 365 license to use the extension in Copilot. | ||
| - You will need to create [local Azure Storage](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage). |
There was a problem hiding this comment.
Let's update the link here to point to the relevant section in the page and remove the en-us locale, https://learn.microsoft.com/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage#running-azurite-from-an-aspnet-project
| - You will need a Microsoft work or school account with [permissions to upload custom Teams applications](https://learn.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading). The account will also need a Microsoft Copilot for Microsoft 365 license to use the extension in Copilot. | ||
| - You will need to create [local Azure Storage](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage). | ||
|
|
||
| ## Setup local Azure Storage |
There was a problem hiding this comment.
Visual Studio 2022 has Azure Storage emulation built in, we should look to use this instead of introducing a dependency on node and the Azurite npm package. See Use the Azurite emulator for local Azure Storage development: Running Azurite from an ASP.NET project
| APP_NAME_SUFFIX=local | ||
|
|
||
| # Generated during provision, you can also add your own variables. | ||
| BOT_ID= |
There was a problem hiding this comment.
This environment variable is not given a value after running Prepare Teams App Dependencies process so can be removed.
| SECRET_STORAGE_ACCOUNT_CONNECTION_STRING=UseDevelopmentStorage=true | ||
| ~~~ | ||
|
|
||
| ### Ports occupied error |
There was a problem hiding this comment.
This isn't relevant to Visual Studio
|
|
||
| This happens if you shut down the debugger and then immediately start your app again. It takes a moment for your app to stop running and release its TCP ports. Just close the error and try again. | ||
|
|
||
| ### The app takes a long time to start after pressing F5 or the debug button |
There was a problem hiding this comment.
This isn't relevant to Visual Studio
| MicrosoftAppPassword: ${{SECRET_AAD_APP_CLIENT_SECRET}} | ||
| MicrosoftAppType: ${{MICROSOFT_APP_TYPE}} | ||
| MicrosoftAppTenantId: ${{MICROSOFT_APP_TENANT_ID}} | ||
| StorageConnectionString: "UseDevelopmentStorage=true" |
There was a problem hiding this comment.
We should avoid hard coding values in the YML file. I would recommend creating an environment variable in the env.local.user file to store this value.
| [Ll]og/ | ||
|
|
||
| # Notification local store | ||
| .notification.localstore.json |
There was a problem hiding this comment.
We should include the following paths:
appsettings.json.vs__azurite*__blobstorage____queuestorage__
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
The test tool isn't used, so this file can be removed.
|
@Jegadeesh-MSFT I've made this PR draft, please mark as ready for review you've completed the requested changes 👍 |
No description provided.