Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated pages.NavigateCrossDomain and updated typedocs #2017

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Deprecated pages.NavigateCrossDomain and updated typedocs #2017

merged 10 commits into from
Jul 10, 2024

Conversation

vikramtha
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

Summarize the changes, including the goals and reasons for this change. Be sure to call out any technical or behavior changes that reviewers should be aware of.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Deprecated pages.NavigateCrossDomain
  2. Updated comments for the v1 NavigateCrossDomain

Validation

Validation performed:

n/a

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

No, only typedoc changes

End-to-end tests added:

na/

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Yes

@vikramtha vikramtha requested a review from a team as a code owner November 1, 2023 19:59
ydogandjiev
ydogandjiev previously approved these changes Nov 1, 2023
View reviewed changes
AE-MS
AE-MS previously requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@vikramtha vikramtha enabled auto-merge (squash) July 2, 2024 17:01
@TrevorJoelHarris TrevorJoelHarris dismissed AE-MS’s stale review July 2, 2024 17:06

Not available for re-reviewing

@vikramtha vikramtha merged commit bd32dfc into main Jul 10, 2024
21 checks passed
@vikramtha vikramtha deleted the vikramtha/deprecateNavigateCrossDomain branch July 10, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorJoelHarris TrevorJoelHarris TrevorJoelHarris approved these changes

@jadahiya-MSFT jadahiya-MSFT jadahiya-MSFT approved these changes

@ydogandjiev ydogandjiev ydogandjiev left review comments

@AE-MS AE-MS Awaiting requested review from AE-MS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vikramtha @ydogandjiev @TrevorJoelHarris @AE-MS @jadahiya-MSFT @KangxuanYe