-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video frame capabilities and attributes #2383
Conversation
): Promise<{ videoFrame: VideoFrame; metadata: { audioInferenceResult?: Uint8Array } }> => { | ||
): Promise<{ | ||
videoFrame: VideoFrame; | ||
metadata: { audioInferenceResult?: Uint8Array; attributes?: ReadonlyMap<string, Uint8Array> }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attributes
will be undefined
for hosts that do not (yet) support using the required capabilities specified by the app. Otherwise, it will be empty for apps that don't specify any required capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about how to contribute to this repo, visit this page.
Description
This updates the internal video frame API to allow a video app to specify required capabilities to be applied to the video frame and also read arbitrary attributes on the video frame added by any of the specified capabilities.
Main changes in the PR:
requiredCapabilities
field toVideoFrameConfig
.attributes
field toVideoFrameData
.extractVideoFrameAndMetadata
to read and populate theattributes
field.Validation
Validation performed:
Unit Tests added:
Updated existing videoEffectsEx unit tests.
End-to-end tests added:
Updated existing VideoEffectsExAPI e2e tests.
Additional Requirements
Change file added:
Yes
Next/remaining steps:
requiredCapabilities
fieldattributes
field