Use suggested naming style in all examples #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some examples marked as _good_ used variable names whose style is explicitly discouraged in section "Naming Conventions". This fixes these inconsistencies, using snake_case for objects and non-factory functions.
|
I think this project is no longer maintained, it would be better to fork it @tarleb and maintain outside of this repo. I'm happy to contribute if you forked it and appended this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples marked as good used variable names whose style is
explicitly discouraged in section "Naming Conventions". This fixes these
inconsistencies, using snake_case for objects and non-factory functions.