Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let users see the full anonymous list of requests added. #4457

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Let users see the full anonymous list of requests added. #4457

wants to merge 15 commits into from

Conversation

maartenheebink
Copy link
Contributor

@tidusjar
Copy link
Member

tidusjar commented Jan 5, 2022

initial changes look good, some failing unit tests :)

@maartenheebink
Copy link
Contributor Author

initial changes look good, some failing unit tests :)

Yea, i was just tinkering with it yesterday. There are some pretty serious bugs still in it.

@tidusjar
Copy link
Member

tidusjar commented Jan 5, 2022

Yeah no worries. I've not pulled the code down and tested it myself yet. But let me know when you think it's good to go and I'll have a crack at it 😀

@maartenheebink @tidusjar
Update src/Ombi/ClientApp/src/app/requests-list/components/movies-gri…
4004c9e 
…d/movies-grid.component.ts

Co-authored-by: Jamie <tidusjar@gmail.com>
@maartenheebink maartenheebink marked this pull request as draft January 5, 2022 17:28
@maartenheebink
Copy link
Contributor Author

@tidusjar could you have a crack at it? Might be very close to completion i guess?

@maartenheebink maartenheebink marked this pull request as ready for review January 9, 2022 12:04
@maartenheebink maartenheebink changed the title WIP: Let users see the full anonymous list of requests added. Let users see the full anonymous list of requests added. Jan 9, 2022
@tidusjar
Copy link
Member

Sure will check it out soon

@tidusjar
Copy link
Member

OK, some initial testing.

From a movie side it all looks good
From a TV show, it seems that we still bring back the user, User c Requested this show and I am logged in as user b
image

It's part of the api/v1/Request/tv/{requestId}/child API call

See here: https://github.com/maartenheebink/Ombi/blob/feature/see_requests/src/Ombi.Core/Engine/TvRequestEngine.cs#L614

@maartenheebink
Copy link
Contributor Author

I'll hop on this soon, in between some other things right now and couldn't/can't find the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tidusjar tidusjar tidusjar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maartenheebink @tidusjar