-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit numpy version to < 2.0 and fix missing dependency #10537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed stats:
|
Speed stats:
|
View latest API docs preview at: https://oneflow-staging.oss-cn-beijing.aliyuncs.com/docs/Oneflow-Inc/oneflow/pr/10537/ |
mosout
approved these changes
Jun 20, 2024
ShawnXuan
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, numpy released version 2.0, which caused oneflow to crash:
Also, we rely on the
typing-extensions
library:oneflow/python/oneflow/framework/check_point_v2.py
Line 32 in 9cf3ee5
Since we depend on the
rich
library, andrich
depends ontyping-extensions
when using Python < 3.9 (https://github.com/Textualize/rich/blob/master/pyproject.toml#L31C1-L31C18),typing-extensions
is automatically installed when installing oneflow on Python < 3.9. However, starting from Python >= 3.9,typing-extensions
is missing.Another issue is that we will install
packaging
if Python < 3.8, but I encounter apackaging
missing issue when using Python == 3.8:this PR:
typing-extensions
.packaging
from Python < 3.8 to Python <= 3.8.