-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRO-446: Extend Helm chart options to support configuring GraphDB cluster and connector security with provided TLS assets #132
Open
Secchol
wants to merge
3
commits into
feature/11-3-features
Choose a base branch
from
GDB-10823-Extend-Helm-Chart-With-TLS-Properties
base: feature/11-3-features
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailradkov
reviewed
Oct 7, 2024
values.yaml
Outdated
# graphdb.connector.SSLEnabled = true | ||
# graphdb.connector.scheme = https | ||
# graphdb.connector.secure = true | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we could provide a truststore without needing to configure a keystone. E.g. if you want GraphDB to trust some external service. This makes enabled
invalid for both.
Secchol
changed the title
Added support for keystore and truststore configuration.
Extend Helm chart options to support configuring GraphDB cluster and connector security with provided TLS assets
Oct 21, 2024
Secchol
force-pushed
the
GDB-10823-Extend-Helm-Chart-With-TLS-Properties
branch
from
October 28, 2024 14:49
9394a09
to
212661c
Compare
mihailradkov
changed the title
Extend Helm chart options to support configuring GraphDB cluster and connector security with provided TLS assets
PRO-446: Extend Helm chart options to support configuring GraphDB cluster and connector security with provided TLS assets
Oct 30, 2024
GraphDB Tomcat and GraphDB gRPC cluster can now be configured with TLS for secure communication with GraphDB. - Added Tomcat TLS configurations under `configuration.tls` - Added gRPC TLS configurations under `cluster.tls` - Updated jobs and scripts to use `https` or `http` depending on whether the Tomcat connector security is configured
mihailradkov
force-pushed
the
GDB-10823-Extend-Helm-Chart-With-TLS-Properties
branch
from
October 30, 2024 15:24
82f8826
to
fe4cdbc
Compare
- Added the protocol in the cronjob for backups - Used volume projection to simplify the statefulset - Read ket/trust stores passwords as files - Renamed privateKey to certificateKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to GDB-11142 , GDB-10534 and GDB-11021
Added support for configuring grpc cluster security with externally provided TLS assets.
The following properties can now be configured through the Helm chart options:
Added support for configuring Tomcat connector security with externally provided TLS assets.
Added support for the following properties :