Add option to create indices from existingConfigmap #153
Conversation
rdstn
requested review from
yaskoo and
mihailradkov
and removed request for
yaskoo
Currently the Helm Chart supports creating new repositories via an existing ConfigMap. For deploying GraphDB as IaC this is quite useful. Unfortunately, there is no way to create indices at install time. This adds the option to provide a existing ConfigMap via values and create an index for one or multiple repositories. The ConfigMap has to consist out of keys that have the same name as the repository. The value is the SPARQL query.
mihailradkov
force-pushed
the
create-indices
branch
from
c5a98b2 to
4eaa602
Compare
values.yaml
Outdated
| ################################ | ||
|
|
||
| indices: | ||
| # Optional configmap containing indices configuration .ttl file(s). |
There was a problem hiding this comment.
The description is not accurate, the job does not expect .ttl files or other repo configurations.
There was a problem hiding this comment.
I change the description to reflect the fact that the name is the repository name and the contents are the SPARQL query in ttl format.
| # Custom Lucene Configurations # | ||
| ################################ | ||
|
|
||
| indices: |
There was a problem hiding this comment.
BTW, this could be used for all kinds of SPARQL update queries. I provisioned a repository with some statements using this. However, it should be used with care as each helm upgrade would trigger the job.
We could merge this as is for now and make it a more generic functionality in the next major release.
There was a problem hiding this comment.
Sounds good! Our use-case was purely indices but I can imagine other queries to be useful. I took inspiration from provision-repositories. Ideally queries should be idempotent to work well with upgrades.
If you make it generic, it might be a good idea to use index creation as an example how a configmap should look like.
Currently the Helm Chart supports creating new repositories via an existing ConfigMap. For deploying GraphDB as IaC this is quite useful. Unfortunately, there is no way to create indices at install time.
This adds the option to provide a existing ConfigMap via values and create an index for one or multiple repositories.
The ConfigMap has to consist out of keys that have the same name as the repository. The value is the SPARQL query.