Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If any patterns are bad, do not allow pulse generation. #5

Closed
wants to merge 1 commit into from

Conversation

tpyoed
Copy link
Contributor

@tpyoed tpyoed commented Nov 24, 2024

If any of the patterns are invalid when they're checked at startup, the state machine is put into stateNop instead of stateIdle.

This keeps bad patterns from being used.

@Onwrikbaar
Copy link
Owner

Hi, and thank you for the contribution. Unfortunately this way a single bad elcon in some pattern would render the whole device useless, which is undesirable. If a bad elcon is actually executed, the code will assert in function getPhase in the BSP, so such a problem is still caught.

On a more general note: I'm not currently soliciting contributions to the firmware, because major changes (especially to the sequencer) are under way, and having to assess and merge PRs slows me down.

@Onwrikbaar Onwrikbaar closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants