[FS]: Add ISOBUS/J1939 Time/Date interface #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad3154
added
enhancement
ad3154
force-pushed
the
adrian/time-date
branch
2 times, most recently
from
c8577a6
to
e68484c
Compare
ad3154
force-pushed
the
adrian/time-date
branch
2 times, most recently
from
dfb452f
to
cc826e7
Compare
GwnDaan
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Lovely! With a few lines we can successfully get the time and date from a CCI1200 terminal:
isobus::TimeDateInterface timeDateInterface(nullptr, nullptr);
timeDateInterface.initialize();
while (running)
{
std::this_thread::sleep_for(std::chrono::milliseconds(5000));
timeDateInterface.request_time_and_date(TestInternalECU);
}
Added an interface for interacting with the time and date PGN. This is related to the ISOUS file server client, where time and date may need to be known for some operations. Also, updated a few more github action versions.
|
GwnDaan
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
How has this been tested?
Since I don't have easy access to a machine with this message present on it, I wrote the interface against the definition on isobus.net, and used unit tests to validate message parsing and construction, as well as our responsiveness to PGN requests for the time/date PGN.