Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC]: Add distance thresholds and handling of default process data #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Jul 27, 2024

Describe your changes

  • Added support for distance interval measurement commands to the TC client
    • Users can use the set_distance function on the TC client now to cause the client to evaluate all TC-configured distance interval measurement commands, which previously weren't really supported. Distance triggers are not often used, but at least we now support it. When the distance set to the client causes any process data variable to need to be resent, the client will now automatically query the user's value callback and send an update to the TC. In general it's very automated, but the user is required to manage the vehicle's total driven distance in the consuming application, maybe by using our speed and distance interfaces or via proprietary means.
  • Added support for defining and automatically querying a consuming application for a DDOP's default process data.
    • The TC requests a special DDI (57343 - Request Default Process Data) from device element 0 when it wants the client to send values to it using the default trigger method. Previously this wasn't really supported via the stack, so this adds generic handling of it. Users can add a callback which will be called when the TC requests this. Inside that callback, the user can tell the TC client to configure any number of default triggers, and we'll error check them against the DDOP content.

Fixes #485

How has this been tested?

  • Tested with TC
  • Tested via unit tests (needs a little improvement yet)

@ad3154 ad3154 added enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard labels Jul 27, 2024
@ad3154 ad3154 self-assigned this Jul 27, 2024
@ad3154 ad3154 force-pushed the adrian/tc-default-process-data branch from 9e5cb09 to 447f766 Compare July 27, 2024 22:44
Copy link

sonarcloud bot commented Jul 27, 2024

@ad3154 ad3154 requested a review from GwnDaan July 27, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iso: task controller Related to the ISO-11783:10 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TC Client] Add a way to generically handle request for the default process data
1 participant