Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete peakcan driver #28

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

JannesBrands
Copy link
Member

Rewrote the pcan driver with all its functionalities. But someone needs to test its functionality, cause I dont own a pcan.

JannesBrands and others added 2 commits September 20, 2023 00:41
builds, driver works, no functional test (no pcan available)
@JannesBrands
Copy link
Member Author

maybe someone with a pcan can test if its working.

Copy link
Member

@Notgnoshi Notgnoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes looks great - thanks for working on this!

I don't have a pcan probe either :(

I think we can go ahead and merge this PR as the target branch is ag/pcan (which also needs to be rebased on top of latest main)

@JannesBrands JannesBrands merged commit 1692205 into Open-Agriculture:ag/pcan Nov 5, 2023
2 of 3 checks passed
@ad3154
Copy link
Member

ad3154 commented Nov 6, 2023

I do have PCAN, so I may be able to try this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants